fix: Check content type before LSP enablement#1552
Merged
rubenporras merged 1 commit intoJun 24, 2026
Merged
Conversation
FlorianKroiss
approved these changes
Jun 23, 2026
FlorianKroiss
left a comment
FlorianKroiss
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! The fix looks straightforward.
Contributor
|
Thank you for the PR! |
Contributor
Author
|
Thanks for the quick merge, and thanks for your work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the order of checks when looking up available language servers.
Before, LSP4E evaluated
mapping.isEnabled(uri)before checking whether the mapping's content type matched the file. For mappings with anenabledWhen, that can be expensive and may load the file as a document even when the mapping does not apply.With this change, the content type is checked first, so
enabledWhenis only evaluated for matching mappings.Fixes #1551